Skip to content

fix: use the updated link checker fork#1475

Merged
Skarlso merged 6 commits into
mainfrom
fix-link-checker
May 21, 2025
Merged

fix: use the updated link checker fork#1475
Skarlso merged 6 commits into
mainfrom
fix-link-checker

Conversation

@Skarlso
Copy link
Copy Markdown
Contributor

@Skarlso Skarlso commented May 21, 2025

What this PR does / why we need it

Which issue(s) this PR fixes

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso Skarlso requested a review from a team as a code owner May 21, 2025 08:40
@github-actions github-actions Bot added kind/bugfix Bug component/github-actions Changes on GitHub Actions or within `.github/` directory size/xs Extra small labels May 21, 2025
@frewilhelm
Copy link
Copy Markdown
Contributor

This will fix #1474

@frewilhelm frewilhelm linked an issue May 21, 2025 that may be closed by this pull request
1 task
@frewilhelm
Copy link
Copy Markdown
Contributor

Did you had any chance to check if this works?

@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented May 21, 2025

I'm looking to what's happening with the error. It's strange because it looks like the regex is wrong, but how did it work then before? :D Because ** should most likely be .* there. But it's weird why ** was working before anyways. Maybe they switched the engine or something. I'm not sure. It's difficult to follow.

@frewilhelm
Copy link
Copy Markdown
Contributor

Yes, I was wondering about the same, when I took a look yesterday. Apparently, it was working fine until the update of the original action.

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@github-actions github-actions Bot added the area/documentation Documentation related label May 21, 2025
Skarlso added 2 commits May 21, 2025 11:15
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso Skarlso force-pushed the fix-link-checker branch from 9e88d30 to 7f52473 Compare May 21, 2025 09:54
@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented May 21, 2025

Okay, the check is now fixed. Funny enough ,{ "pattern": "^{{.*}}$" } we had in there actually doesn't work, because it's being translated into the regex I added now.

For example:


  ERROR: 2 dead links found in ./examples/lib/tour/docsrc/03-working-with-credentials/README.md !
  [✖] %7B%7Bgetting-started-walkthrough%7D%7D → Status: 400
  [✖] %7B%7Bdescribe-version%7D%7D → Status: 400

Comment thread .github/config/markdown-link-check.json
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented May 21, 2025

Previous failed run: https://github.com/open-component-model/ocm/actions/runs/15159082663/job/42620755562
Previous passed run when I edited a markdown: https://github.com/open-component-model/ocm/actions/runs/15159137065

@Skarlso Skarlso merged commit 7cecb36 into main May 21, 2025
25 checks passed
@Skarlso Skarlso deleted the fix-link-checker branch May 21, 2025 18:23
@ocmbot ocmbot Bot added this to the 2025-Q2 milestone May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/documentation Documentation related component/github-actions Changes on GitHub Actions or within `.github/` directory kind/bugfix Bug size/xs Extra small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub actions workflow Markdown is failing

3 participants